Add Llama RPC providers #222
Merged
+90
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanasa
commented
Jun 11, 2024
| @@ -36,6 +36,7 @@ type EthMainnetService = variant { | |||
| BlockPi; | |||
| Cloudflare; | |||
| PublicNode; | |||
| Llama; | |||
There was a problem hiding this comment.
Currently using Llama in place of LlamaNodes since the API domain name is llamarpc.com. Otherwise, also having PublicNode could create some confusion about when to include an s at the end for people unfamiliar with these individual providers.
Totally open to hearing other perspectives on this in case it makes more sense to use LlamaNodes.
There was a problem hiding this comment.
I thought those were coming from the company name, which in that case LlamaNodes and PublicNode make perfect sense, and not from the API domain name. A priori I would say that the company name is more stable than the domain name, that's why I would tend to stick to the company name, but that's not a strong opinion.
dfx-json
approved these changes
Jun 11, 2024
gregorydemay
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes Llama RPC providers in the local replica and updates the Candid interface.
Pending !19761.